[LLVMdev] support for division by constant in APInt

Tanya Lattner tonic at nondot.org
Mon Apr 27 13:00:34 PDT 2009


On Apr 27, 2009, at 11:33 AM, Misha Brukman wrote:

> On Mon, Apr 27, 2009 at 9:45 AM, Jay Foad <jay.foad at gmail.com> wrote:
> > The patch looks fine to me, does it pass regression tests etc?
>
> Yes, I've just run a successful "make" in the test-suite module. It
> took hours! Is there a smaller set of regression tests I could run for
> changes like this in future?
>
> "make unittests" is a smaller set of tests, but given that it  
> doesn't have particularly high coverage, it shouldn't be the only  
> tests you run.
>
> There are unittests for APInt, but they wouldn't cover a refactoring  
> change such as this one.  Please feel free to add a unittest with  
> your change.

'make check' runs regression tests.

You can also run a subset of llvm-test (test-suite), but its always  
better if you can run all of them.

-Tanya

>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090427/54eba206/attachment.html>


More information about the llvm-dev mailing list