[LLVMdev] support for division by constant in APInt
brukman at gmail.com
Mon Apr 27 11:33:33 PDT 2009
On Mon, Apr 27, 2009 at 9:45 AM, Jay Foad <jay.foad at gmail.com> wrote:
> > The patch looks fine to me, does it pass regression tests etc?
> Yes, I've just run a successful "make" in the test-suite module. It
> took hours! Is there a smaller set of regression tests I could run for
> changes like this in future?
"make unittests" is a smaller set of tests, but given that it doesn't have
particularly high coverage, it shouldn't be the only tests you run.
There are unittests for APInt, but they wouldn't cover a refactoring change
such as this one. Please feel free to add a unittest with your change.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev