<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 27, 2009, at 11:33 AM, Misha Brukman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Mon, Apr 27, 2009 at 9:45 AM, Jay Foad <span dir="ltr"><<a href="mailto:jay.foad@gmail.com">jay.foad@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">> The patch looks fine to me, does it pass regression tests etc?<br> <br> </div>Yes, I've just run a successful "make" in the test-suite module. It<br> took hours! Is there a smaller set of regression tests I could run for<br> changes like this in future?</blockquote><div><br>"make unittests" is a smaller set of tests, but given that it doesn't have particularly high coverage, it shouldn't be the only tests you run.<br><br>There are unittests for APInt, but they wouldn't cover a refactoring change such as this one. Please feel free to add a unittest with your change.</div></div></blockquote><div><br></div>'make check' runs regression tests. </div><div><br></div><div>You can also run a subset of llvm-test (test-suite), but its always better if you can run all of them.</div><div><br></div><div>-Tanya</div><div><br></div><div><blockquote type="cite"><div class="gmail_quote"><div><br> </div></div> _______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></blockquote></div><br></body></html>