[LLVMdev] x86 calling conventions refactoring
evan.cheng at apple.com
Fri Jan 4 02:24:44 PST 2008
This looks good to me! If you have run it through a round of testing,
On Jan 3, 2008, at 9:35 AM, Gordon Henriksen wrote:
> On 2008-01-01, at 20:05, Gordon Henriksen wrote:
>> The attachment supersedes the previous patch. It incorporates some
>> feedback from Anton and takes the next step of merging the largely
>> duplicated calling convention logic in X86ISelLowering.
>> • LowerCCCArguments, LowerX86_64CCCArguments and
>> LowerFastCCArguments are merged and inlined directly into
>> • I moved LowerFORMAL_ARGUMENTS to the location where
>> LowerCCCArguments was in order to facilitate review (otherwise the
>> diff would contain no useful deltas), but it should go back where
>> it belongs afterwards.
>> • LowerX86_64CCCCallTo and LowerX86_64CCCCallTo were consolidated
>> with LowerCCCCallTo.
>> • I haven't yet tackled merging LowerCCCCallTo and LowerTailCallTo.
>> There net savings is 405 LOC.
>> I'd appreciate tests on Windows and x86-64 hosts, since some of
>> the logic was rather convoluted.
> This rebases this patch to r45536 (http://lists.cs.uiuc.edu/
> pipermail/llvm-commits/Week-of-Mon-20071231/056756.html) and I also
> finished merging LowerCCC- and -TailCallTo.
> -508 LOC!
> — Gordon
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev