[LLVMdev] x86 calling conventions refactoring

Gordon Henriksen gordonhenriksen at mac.com
Thu Jan 3 09:35:02 PST 2008

On 2008-01-01, at 20:05, Gordon Henriksen wrote:

> The attachment supersedes the previous patch. It incorporates some  
> feedback from Anton and takes the next step of merging the largely  
> duplicated calling convention logic in X86ISelLowering.
> • LowerCCCArguments, LowerX86_64CCCArguments and  
> LowerFastCCArguments are merged and inlined directly into  
> • I moved LowerFORMAL_ARGUMENTS to the location where  
> LowerCCCArguments was in order to facilitate review (otherwise the  
> diff would contain no useful deltas), but it should go back where it  
> belongs afterwards.
> • LowerX86_64CCCCallTo and LowerX86_64CCCCallTo were consolidated  
> with LowerCCCCallTo.
> • I haven't yet tackled merging LowerCCCCallTo and LowerTailCallTo.
> There net savings is 405 LOC.
> I'd appreciate tests on Windows and x86-64 hosts, since some of the  
> logic was rather convoluted.

This rebases this patch to r45536 (http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20071231/056756.html 
) and I also finished merging LowerCCC- and -TailCallTo.

-508 LOC!

— Gordon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080103/b5cf4352/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86cconv3.patch
Type: application/octet-stream
Size: 60741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080103/b5cf4352/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080103/b5cf4352/attachment-0001.html>

More information about the llvm-dev mailing list