<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">This looks good to me! If you have run it through a round of testing, please commit.<div><br class="webkit-block-placeholder"></div><div>Thanks,</div><div><br class="webkit-block-placeholder"></div><div>Evan</div><div><br><div><div>On Jan 3, 2008, at 9:35 AM, Gordon Henriksen wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><pre><pre><div><div>On 2008-01-01, at 20:05, Gordon Henriksen wrote:</div><div><br></div><div></div><blockquote type="cite"><div><span class="Apple-style-span" style="-webkit-text-stroke-width: -1; ">The attachment supersedes the previous patch. It incorporates some feedback from Anton and takes the next step of merging the largely duplicated calling convention logic in X86ISelLowering.</span></div><div><br></div><div>• LowerCCCArguments, LowerX86_64CCCArguments and LowerFastCCArguments are merged and inlined directly into LowerFORMAL_ARGUMENTS.</div><div>• I moved LowerFORMAL_ARGUMENTS to the location where LowerCCCArguments was in order to facilitate review (otherwise the diff would contain no useful deltas), but it should go back where it belongs afterwards.</div><div>• LowerX86_64CCCCallTo and LowerX86_64CCCCallTo were consolidated with LowerCCCCallTo.</div><div>• I haven't yet tackled merging LowerCCCCallTo and LowerTailCallTo.</div><div><br></div><div>There net savings is 405 LOC.</div><div><br></div><div>I'd appreciate tests on Windows and x86-64 hosts, since some of the logic was rather convoluted.</div><div></div></blockquote><div><br></div><div>This rebases this patch to r45536 (<a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20071231/056756.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20071231/056756.html</a>) and I also finished merging LowerCCC- and -TailCallTo.</div><div><br class="webkit-block-placeholder"></div><div>-508 LOC!</div><div><br></div><div>— Gordon</div><div><br class="webkit-block-placeholder"></div><div></div></div></pre></pre><span><x86cconv3.patch></span><pre><pre><div><div></div></div></pre></pre><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">LLVM Developers mailing list</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <span class="Apple-converted-space"> </span><a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a></div> </blockquote></div><br></div></body></html>