[LLVMdev] Trailing whitespace removal (important for CVS users!)

Reid Spencer reid at x10sys.com
Thu Apr 21 14:11:01 PDT 2005

On Thu, 2005-04-21 at 15:51 -0500, Misha Brukman wrote:

> On Thu, Apr 21, 2005 at 03:57:54PM -0500, Chris Lattner wrote:
> > On Thu, 21 Apr 2005, Reid Spencer wrote:
> > >Why not put all this into a pre-commit filter in CVS and be done with
> > >it? We'd never be bothered with it again as it would never be
> > >committed again.
> > 
> > I'd rather not have CVS commit scripts mucking with the code.  
> I think Reid means to have a script that *prevents* checkin of code that
> does not conform to some standards, verified by a pre-checking script.
> The script would *not* be auto-modifying code before/after checkin.

Yeah, that's what I meant. While we're at it, you could run something
like "indent" to validate the coding style. It would just reject the
commit if it found problems.


> My only issue is that it slows down the commits for all committers...
> But it would force everyone to follow the coding standard(s)!

True, but think about how much time we waste dealing with formatting and
style issues. Its a trade off. I'd rather have the computer think about
it than the developers. There's also lost productivity when faced with
unwarranted diffs and code in style that isn't conforming.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20050421/f2faafde/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20050421/f2faafde/attachment.sig>

More information about the llvm-dev mailing list