<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.3.2">
</HEAD>
<BODY>
On Thu, 2005-04-21 at 15:51 -0500, Misha Brukman wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">On Thu, Apr 21, 2005 at 03:57:54PM -0500, Chris Lattner wrote:</FONT>
<FONT COLOR="#000000">> On Thu, 21 Apr 2005, Reid Spencer wrote:</FONT>
<FONT COLOR="#000000">> >Why not put all this into a pre-commit filter in CVS and be done with</FONT>
<FONT COLOR="#000000">> >it? We'd never be bothered with it again as it would never be</FONT>
<FONT COLOR="#000000">> >committed again.</FONT>
<FONT COLOR="#000000">> </FONT>
<FONT COLOR="#000000">> I'd rather not have CVS commit scripts mucking with the code. </FONT>
<FONT COLOR="#000000">I think Reid means to have a script that *prevents* checkin of code that</FONT>
<FONT COLOR="#000000">does not conform to some standards, verified by a pre-checking script.</FONT>
<FONT COLOR="#000000">The script would *not* be auto-modifying code before/after checkin.</FONT>
</PRE>
</BLOCKQUOTE>
Yeah, that's what I meant. While we're at it, you could run something like "indent" to validate the coding style. It would just reject the commit if it found problems.<BR>
<BR>
Reid
<BLOCKQUOTE TYPE=CITE>
<PRE>
<FONT COLOR="#000000">My only issue is that it slows down the commits for all committers...</FONT>
<FONT COLOR="#000000">But it would force everyone to follow the coding standard(s)!</FONT>
</PRE>
</BLOCKQUOTE>
<BR>
True, but think about how much time we waste dealing with formatting and style issues. Its a trade off. I'd rather have the computer think about it than the developers. There's also lost productivity when faced with unwarranted diffs and code in style that isn't conforming.<BR>
<BR>
Reid
</BODY>
</HTML>