[PATCH] D156287: [RISCV] Add codegen support for bf16 vector

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 20:49:35 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:1953
 // Vector
 include "RISCVInstrInfoV.td"
 include "RISCVInstrInfoZvk.td"
----------------
What about moving `RISCVInstrInfoZvfbf.td` up instead of including it in `RISCVInstrInfoV.td`?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3550
+    defvar mx = m.MX;
+    defvar WriteVFWMulAddV_MX = !cast<SchedWrite>("WriteVFWMulAddV_" # mx);
+    defvar ReadVFWMulAddV_MX = !cast<SchedRead>("ReadVFWMulAddV_" # mx);
----------------
Do we need seperate SchedReadWrite for BF16 instructions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156287/new/

https://reviews.llvm.org/D156287



More information about the llvm-commits mailing list