[PATCH] D156287: [RISCV] Add codegen support for bf16 vector

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:235
 
+// Used for widening bf16 instructions..
+defvar BFPListW = [SCALAR_BF16];
----------------
Extra `.`


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:7359
                              AllWidenableFloatVectors>;
+defm : VPatTernaryW_VV_VX_RM<"int_riscv_vfwmaccbf16", "PseudoVFWMACCBF16", 
+                             AllWidenableBFloatToFloatVectors>;
----------------
Do we need to check that Zvfbfwma is enabled?


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfncvtbf16-f-f.ll:24
+    <vscale x 1 x float> %0,
+    iXLen 0, iXLen %1)
+
----------------
Use 7 for rounding mode?


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfwmaccbf16.ll:25
+    <vscale x 1 x bfloat> %2,
+    iXLen 0, iXLen %3, iXLen 0)
+
----------------
use 7 for rounding mode


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156287/new/

https://reviews.llvm.org/D156287