[PATCH] D86202: [yaml2obj] - Make the 'Machine' key optional.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:557
+
+  unsigned getEMachine() const;
 };
----------------
You can probably just call this `getMachine`.


================
Comment at: llvm/test/tools/obj2yaml/ELF/duplicate-symbol-and-section-names.yaml:30
 # CASE1-NEXT:   Type:    ET_REL
-# CASE1-NEXT:   Machine: EM_X86_64
+# CASE1-NEXT:   Machine: EM_NONE
 # CASE1-NEXT: Sections:
----------------
Should we (in a separate change) only emit the Machine line if we are not EM_NONE?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86202/new/

https://reviews.llvm.org/D86202