[PATCH] D85649: [AArch64] PAC/BTI code generation for LLVM generated functions

[David Tellenbach via Phabricator via llvm-commits]

tellenbach added a comment.

Does this conflict with D80791 <https://reviews.llvm.org/D80791>? Other than that it lgtm.



================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:149
+  /// SignWithBKey enables use of the B keyfor PAC-RET, otherwise use A key.
+  bool SignWithBKey;
+
----------------
chill wrote:
> tellenbach wrote:
> > The key type could in fact also be made an enum just like you did for the type of return address signing but no strong opinion here.
> If I would be bothered to change it, I'd rather go in the opposite direction, replace the `SignReturnAddress` by two booleans. That'll remove the need for a typedef and make the code less verbose.
Yep, makes sense. Anyway, the current version is fine for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85649/new/

https://reviews.llvm.org/D85649