[PATCH] D86202: [yaml2obj] - Make the 'Machine' key optional.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 04:35:31 PDT 2020 

grimar updated this revision to Diff 286535.
grimar marked an inline comment as done.
grimar added a comment.

- Addressed review comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86202/new/

https://reviews.llvm.org/D86202

Files:
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/test/tools/llvm-readobj/ELF/addrsig.test
  llvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test
  llvm/test/tools/llvm-readobj/ELF/broken-dynsym-link.test
  llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test
  llvm/test/tools/llvm-readobj/ELF/check-output-order.test
  llvm/test/tools/llvm-readobj/ELF/dependent-libraries.test
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-empty.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-malformed.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-not-in-pt-dynamic.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test
  llvm/test/tools/llvm-readobj/ELF/dynamic-table-dtnull.s
  llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test
  llvm/test/tools/llvm-readobj/ELF/file-header-abi-version.test
  llvm/test/tools/llvm-readobj/ELF/file-header-os-abi.test
  llvm/test/tools/llvm-readobj/ELF/file-name.test
  llvm/test/tools/llvm-readobj/ELF/file-types.test
  llvm/test/tools/llvm-readobj/ELF/gnu-note-size.test
  llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
  llvm/test/tools/llvm-readobj/ELF/gnu-section-mapping-no-phdrs.test
  llvm/test/tools/llvm-readobj/ELF/gnu-section-mapping.test
  llvm/test/tools/llvm-readobj/ELF/gnuhash.test
  llvm/test/tools/llvm-readobj/ELF/groups.test
  llvm/test/tools/llvm-readobj/ELF/hash-histogram.test
  llvm/test/tools/llvm-readobj/ELF/hash-symbols.test
  llvm/test/tools/llvm-readobj/ELF/hash-table.test
  llvm/test/tools/llvm-readobj/ELF/headers.test
  llvm/test/tools/llvm-readobj/ELF/hex-dump.test
  llvm/test/tools/llvm-readobj/ELF/hidden-versym.test
  llvm/test/tools/llvm-readobj/ELF/invalid-shstrndx.test
  llvm/test/tools/llvm-readobj/ELF/linker-options.test
  llvm/test/tools/llvm-readobj/ELF/malformed-pt-dynamic.test
  llvm/test/tools/llvm-readobj/ELF/many-sections.s
  llvm/test/tools/llvm-readobj/ELF/needed-libs.test
  llvm/test/tools/llvm-readobj/ELF/no-phdrs.test
  llvm/test/tools/llvm-readobj/ELF/no-relocs.test
  llvm/test/tools/llvm-readobj/ELF/no-shdrs.test
  llvm/test/tools/llvm-readobj/ELF/non-dynamic-in-pt-dynamic.test
  llvm/test/tools/llvm-readobj/ELF/note-amdgpu.test
  llvm/test/tools/llvm-readobj/ELF/note-core-ntfile-bad.test
  llvm/test/tools/llvm-readobj/ELF/note-core-ntfile.test
  llvm/test/tools/llvm-readobj/ELF/note-core.test
  llvm/test/tools/llvm-readobj/ELF/program-headers.test
  llvm/test/tools/llvm-readobj/ELF/section-flags-os-proc.test
  llvm/test/tools/llvm-readobj/ELF/section-flags.test
  llvm/test/tools/llvm-readobj/ELF/section-symbols.test
  llvm/test/tools/llvm-readobj/ELF/section-types.test
  llvm/test/tools/llvm-readobj/ELF/sections-no-section-header-string-table.test
  llvm/test/tools/llvm-readobj/ELF/sections.test
  llvm/test/tools/llvm-readobj/ELF/stack-sizes.test
  llvm/test/tools/llvm-readobj/ELF/stackmap.test
  llvm/test/tools/llvm-readobj/ELF/string-dump.test
  llvm/test/tools/llvm-readobj/ELF/symbol-64bit.test
  llvm/test/tools/llvm-readobj/ELF/symbol-binding.test
  llvm/test/tools/llvm-readobj/ELF/symbol-shndx.test
  llvm/test/tools/llvm-readobj/ELF/symbol-types.test
  llvm/test/tools/llvm-readobj/ELF/symbol-visibility.test
  llvm/test/tools/llvm-readobj/ELF/symbols.test
  llvm/test/tools/llvm-readobj/ELF/thin-archive-paths.test
  llvm/test/tools/llvm-readobj/ELF/types.test
  llvm/test/tools/llvm-readobj/ELF/unwind.test
  llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test
  llvm/test/tools/llvm-readobj/ELF/verneed-flags.yaml
  llvm/test/tools/llvm-readobj/ELF/verneed-invalid.test
  llvm/test/tools/llvm-readobj/ELF/versioninfo.test
  llvm/test/tools/llvm-readobj/ELF/versym-invalid.test
  llvm/test/tools/llvm-readobj/ELF/wrong-shstrtab-type.test
  llvm/test/tools/obj2yaml/ELF/DWARF/debug-aranges.yaml
  llvm/test/tools/obj2yaml/ELF/call-graph-profile-section.yaml
  llvm/test/tools/obj2yaml/ELF/duplicate-symbol-and-section-names.yaml
  llvm/test/tools/obj2yaml/ELF/dynamic-section.yaml
  llvm/test/tools/obj2yaml/ELF/entsize.yaml
  llvm/test/tools/obj2yaml/ELF/gnu-hash-section.yaml
  llvm/test/tools/obj2yaml/ELF/gnu-unique-symbols.yaml
  llvm/test/tools/obj2yaml/ELF/hash-section.yaml
  llvm/test/tools/obj2yaml/ELF/implicit-sections-order.yaml
  llvm/test/tools/obj2yaml/ELF/invalid-section-name.yaml
  llvm/test/tools/obj2yaml/ELF/linker-options.yaml
  llvm/test/tools/obj2yaml/ELF/llvm-addrsig-section.yaml
  llvm/test/tools/obj2yaml/ELF/llvm-deplibs-section.yaml
  llvm/test/tools/obj2yaml/ELF/no-symtab.yaml
  llvm/test/tools/obj2yaml/ELF/note-section.yaml
  llvm/test/tools/obj2yaml/ELF/null-section.yaml
  llvm/test/tools/obj2yaml/ELF/program-headers.yaml
  llvm/test/tools/obj2yaml/ELF/rel-rela-section.yaml
  llvm/test/tools/obj2yaml/ELF/reladyn-section-shinfo.yaml
  llvm/test/tools/obj2yaml/ELF/relr-section.yaml
  llvm/test/tools/obj2yaml/ELF/section-group.yaml
  llvm/test/tools/obj2yaml/ELF/sections-info.yaml
  llvm/test/tools/obj2yaml/ELF/shinfo.yaml
  llvm/test/tools/obj2yaml/ELF/shlink.yaml
  llvm/test/tools/obj2yaml/ELF/sht-symtab-shndx.yaml
  llvm/test/tools/obj2yaml/ELF/stack-sizes.yaml
  llvm/test/tools/obj2yaml/ELF/symbol-type.yaml
  llvm/test/tools/obj2yaml/ELF/symbol-visibility.yaml
  llvm/test/tools/obj2yaml/ELF/verdef-section.yaml
  llvm/test/tools/obj2yaml/ELF/verneed-section.yaml
  llvm/test/tools/obj2yaml/ELF/versym-section.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-gnu-pubnames.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-gnu-pubtypes.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-pubnames.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-pubtypes.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-ranges.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-str-offsets.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml
  llvm/test/tools/yaml2obj/ELF/DWARF/empty-dwarf-entry.yaml
  llvm/test/tools/yaml2obj/ELF/abiversion.yaml
  llvm/test/tools/yaml2obj/ELF/call-graph-profile-section.yaml
  llvm/test/tools/yaml2obj/ELF/class-endianness.yaml
  llvm/test/tools/yaml2obj/ELF/comdat-broken-info.yaml
  llvm/test/tools/yaml2obj/ELF/comdat-broken-members.yaml
  llvm/test/tools/yaml2obj/ELF/comdat-broken.yaml
  llvm/test/tools/yaml2obj/ELF/content-array.yaml
  llvm/test/tools/yaml2obj/ELF/custom-fill.yaml
  llvm/test/tools/yaml2obj/ELF/custom-null-section.yaml
  llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml
  llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml
  llvm/test/tools/yaml2obj/ELF/dynamic-section-i386.yaml
  llvm/test/tools/yaml2obj/ELF/dynamic-section-raw-content.yaml
  llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
  llvm/test/tools/yaml2obj/ELF/dynamic-symbols.yaml
  llvm/test/tools/yaml2obj/ELF/dynsymtab-implicit-sections-size-content.yaml
  llvm/test/tools/yaml2obj/ELF/dynsymtab-shlink.yaml
  llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml
  llvm/test/tools/yaml2obj/ELF/ent-size.yaml
  llvm/test/tools/yaml2obj/ELF/explicit-dynsym-no-dynstr.yaml
  llvm/test/tools/yaml2obj/ELF/gnu-hash-section.yaml
  llvm/test/tools/yaml2obj/ELF/gnu-unique-symbols.yaml
  llvm/test/tools/yaml2obj/ELF/hash-section.yaml
  llvm/test/tools/yaml2obj/ELF/header-elfdatanone.yaml
  llvm/test/tools/yaml2obj/ELF/header-osabi.yaml
  llvm/test/tools/yaml2obj/ELF/header-sh-fields.yaml
  llvm/test/tools/yaml2obj/ELF/implicit-sections-addr.yaml
  llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml
  llvm/test/tools/yaml2obj/ELF/implicit-sections-types.yaml
  llvm/test/tools/yaml2obj/ELF/implicit-sections.yaml
  llvm/test/tools/yaml2obj/ELF/invalid-docnum.yaml
  llvm/test/tools/yaml2obj/ELF/linker-options.yaml
  llvm/test/tools/yaml2obj/ELF/llvm-addrsig-section.yaml
  llvm/test/tools/yaml2obj/ELF/llvm-deplibs-section.yaml
  llvm/test/tools/yaml2obj/ELF/local-symbols.yaml
  llvm/test/tools/yaml2obj/ELF/no-phdrs.yaml
  llvm/test/tools/yaml2obj/ELF/none-value.yaml
  llvm/test/tools/yaml2obj/ELF/note-section.yaml
  llvm/test/tools/yaml2obj/ELF/output-limit.yaml
  llvm/test/tools/yaml2obj/ELF/override-shflags.yaml
  llvm/test/tools/yaml2obj/ELF/override-shname.yaml
  llvm/test/tools/yaml2obj/ELF/override-shoffset.yaml
  llvm/test/tools/yaml2obj/ELF/override-shsize.yaml
  llvm/test/tools/yaml2obj/ELF/override-shtype.yaml
  llvm/test/tools/yaml2obj/ELF/program-header-address.yaml
  llvm/test/tools/yaml2obj/ELF/program-header-align.yaml
  llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml
  llvm/test/tools/yaml2obj/ELF/program-header-size-offset.yaml
  llvm/test/tools/yaml2obj/ELF/program-header.yaml
  llvm/test/tools/yaml2obj/ELF/reloc-sec-entry-size.yaml
  llvm/test/tools/yaml2obj/ELF/reloc-sec-info.yaml
  llvm/test/tools/yaml2obj/ELF/relr-section.yaml
  llvm/test/tools/yaml2obj/ELF/section-address-assign.yaml
  llvm/test/tools/yaml2obj/ELF/section-headers-exclude.yaml
  llvm/test/tools/yaml2obj/ELF/section-headers.yaml
  llvm/test/tools/yaml2obj/ELF/section-link.yaml
  llvm/test/tools/yaml2obj/ELF/section-offset.yaml
  llvm/test/tools/yaml2obj/ELF/section-ordering.yaml
  llvm/test/tools/yaml2obj/ELF/section-size-content.yaml
  llvm/test/tools/yaml2obj/ELF/section-unnamed.yaml
  llvm/test/tools/yaml2obj/ELF/sh-addralign.yaml
  llvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml
  llvm/test/tools/yaml2obj/ELF/stack-sizes.yaml
  llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-flags.yaml
  llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-size-content.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-binding.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-index.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-name.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-type.yaml
  llvm/test/tools/yaml2obj/ELF/symbol-visibility.yaml
  llvm/test/tools/yaml2obj/ELF/symbols-binding-order.yaml
  llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-flags.yaml
  llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml
  llvm/test/tools/yaml2obj/ELF/symtab-shlink.yaml
  llvm/test/tools/yaml2obj/ELF/symtab-shtype.yaml
  llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
  llvm/test/tools/yaml2obj/ELF/verneed-section.yaml
  llvm/test/tools/yaml2obj/ELF/versym-section.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86202.286535.patch
Type: text/x-patch
Size: 242569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200819/c3efa218/attachment-0001.bin>

More information about the llvm-commits mailing list