[PATCH] D76427: [AMDGPU][RFC] Use default value for PrivateLabelPrefix

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

It seems like we have been emitting these since at least 2014, but I haven't been able to identify exactly why, or who is using them.  The only use I see of these in LLVM currently is in llvm-objdump, where we use a symbolizer to get symbolic operands for local branches (e.g. "s_branch BB1_4" instead of "s_branch 51" or "s_branch 51 <BB1_4>"). Other targets do not generally rely on a symbolizer here, and I think we should follow suite, but as some people rely on disassembly being "re-assembleable" on a best-effort basis this will likely break a number of things.

In summary I have wanted to land this patch for a while, but haven't prioritized fixing all the places it will break. One thing we discussed was extending llvm-objdump and other tools to do a 2-pass disassembly, where the first pass essentially materializes temporary labels for all the branch targets it identifies, and the second pass can use these to generate nice labels and use them for the branches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76427/new/

https://reviews.llvm.org/D76427