[PATCH] D73078: [VPlan] Use consecutive numbers to print VPValues instead of addresses.

Thu Mar 19 05:21:55 PDT 2020

foad added a comment.

In D73078#1908014 <https://reviews.llvm.org/D73078#1908014>, @fhahn wrote:

> In D73078#1907795 <https://reviews.llvm.org/D73078#1907795>, @RKSimon wrote:
>
> > @fhahn This is causing a msvc warning: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/22465/steps/test-check-all/logs/warnings%20%281%29
> >
> >   C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\unittests\Transforms\Vectorize\VPlanTest.cpp(231): warning C4129: 'l': unrecognized character escape sequence
> >
>
>
> Hmm I am not sure, but it seems like this might be a bug in Visual Studio :( I don't think it should interpret/warn about escape sequences in a raw string literal. I'll try to get a work-around.

We're seeing this too. Did you come up with anything? Perhaps we should add C4129 to the big list of disabled warnings (https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/HandleLLVMOptions.cmake#L515)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73078/new/

https://reviews.llvm.org/D73078