[PATCH] D76427: [AMDGPU][RFC] Use default value for PrivateLabelPrefix

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi created this revision.
Flakebi added reviewers: arsenm, nhaehnle.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

Setting this to an empty string has the effect that all local symbols
`BB0_0`, `BB0_1`, etc. are emitted into object files. Leaving it at the
default value `.L` has the effect that they are removed when creating the
object file.

The symbol section of the object file stays unmodified in llpc, so all
the basic block symbols currently end up in our pipeline elfs.

(all the tests need to be updated to use the prefix, these changes are
not included to not clutter up the diff, so tests are failing)

Matt: You know this code, does this break things somewhere else?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76427

Files:
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp


Index: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
+++ llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
@@ -28,7 +28,6 @@
   MaxInstLength = (TT.getArch() == Triple::amdgcn) ? 20 : 16;
   SeparatorString = "\n";
   CommentString = ";";
-  PrivateLabelPrefix = "";
   InlineAsmStart = ";#ASMSTART";
   InlineAsmEnd = ";#ASMEND";
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76427.251347.patch
Type: text/x-patch
Size: 477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200319/f94255d6/attachment-0001.bin>