[PATCH] D76279: [DebugInfo] Fix multi-byte entry values in call site values

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 01:04:22 PDT 2020


djtodoro added a comment.

In D76279#1926635 <https://reviews.llvm.org/D76279#1926635>, @dstenb wrote:

> In D76279#1926497 <https://reviews.llvm.org/D76279#1926497>, @djtodoro wrote:
>
> > LGTM! Thanks!
> >
> > So, this was causing the wrong call_site_value for the parameter only?
>
>
> Yes, the `DW_AT_location` was correct, so it was only the call site value that was incorrect.
>
> In the attached test case the call site parameter entry would be printed as the following by llvm-dwardump:
>
>   0x0000004c:       DW_TAG_GNU_call_site_parameter
>                       DW_AT_location	(DW_OP_regx B0)
>                       DW_AT_GNU_call_site_value	(DW_OP_GNU_entry_value(DW_OP_regx W0)
>
>
> W0 has DWARF number 0, so presumably it just used the following End of Children mark for the `DW_OP_regx` operand.


OK, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76279/new/

https://reviews.llvm.org/D76279





More information about the llvm-commits mailing list