[PATCH] D76279: [DebugInfo] Fix multi-byte entry values in call site values

[David Stenberg via Phabricator via llvm-commits]

dstenb marked an inline comment as done.
dstenb added a comment.

Thanks for the reviews! I'll land this shortly.



================
Comment at: llvm/include/llvm/CodeGen/DIE.h:567
+      push_back(*TmpNode);
+    } while (IterNode != FirstNode);
+
----------------
vsk wrote:
> Is IntrusiveBackList a circularly linked list, with an always-available pointer to the last element? If so, this lgtm, as the loop will terminate after going 'one past' the last node.
> 
> (This is outside the scope of this patch, but: it'd be really nice to check in some doxygen for IntrusiveBackList.)
Yes, it is implementation-wise a circularly linked list, but it has a non-circular iterator interface.

(If I get some extra time this week, I can try to upload a patch that adds some very basic doxygen comments for the classes.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76279/new/

https://reviews.llvm.org/D76279