[PATCH] D76279: [DebugInfo] Fix multi-byte entry values in call site values

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 11:16:55 PDT 2020


vsk added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DIE.h:567
+      push_back(*TmpNode);
+    } while (IterNode != FirstNode);
+
----------------
Is IntrusiveBackList a circularly linked list, with an always-available pointer to the last element? If so, this lgtm, as the loop will terminate after going 'one past' the last node.

(This is outside the scope of this patch, but: it'd be really nice to check in some doxygen for IntrusiveBackList.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76279/new/

https://reviews.llvm.org/D76279





More information about the llvm-commits mailing list