[PATCH] D73498: [NFC] Remove extra headers included in Loop Unroll and LoopUnrollAndJam files

Anh Tuyen Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 14:34:15 PST 2020


anhtuyen added a comment.

Thanks, David @dmgreen 
You are right that many of the headers in my list are included transitively. Other than AssumptionCache and Dominators and Debug, can you give me names of those you like to be included explicitly even if the compilation can go without them? I will keep them untouched.
By the way, I am aware of what Whitney is working on. I am refactoring the LoopUnrollAndJam to three classes:  1. new pass manager 2. old pass manager 3. the actual implementation, which is used by both 1 and 2.

A side note, but I just noticed I had mistakenly added David Greene instead of you as a reviewer!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73498/new/

https://reviews.llvm.org/D73498





More information about the llvm-commits mailing list