[PATCH] D73498: [NFC] Remove extra headers included in Loop Unroll and LoopUnrollAndJam files

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 04:32:24 PST 2020


dmgreen added a comment.

> By the way, I am aware of what Whitney is working on. I am refactoring the LoopUnrollAndJam to three classes:  1. new pass manager 2. old pass manager 3. the actual implementation, which is used by both 1 and 2.

Sounds good. So long as you know what each other are up to.

You are essentially replacing tryToUnrollAndJamLoop with a class? As opposed to being static functions?

> You are right that many of the headers in my list are included transitively. Other than AssumptionCache and Dominators and Debug, can you give me names of those you like to be included explicitly even if the compilation can go without them? I will keep them untouched.

Best bet is probably to keep all the ones that look like they are obviously used in the file, and I can let you know if any of the others that are still removed should be kept around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73498/new/

https://reviews.llvm.org/D73498





More information about the llvm-commits mailing list