[PATCH] D73498: [NFC] Remove extra headers included in Loop Unroll and LoopUnrollAndJam files

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 13:57:31 PST 2020


dmgreen added subscribers: Whitney, dmgreen.
dmgreen added a comment.

A lot of these are required, and I think will be included transitively if not included directly. Things like AssumptionCache and Dominators and Debug will all be made of use of inside these passes. It's probably better to be explicit about them and leave in those includes that are used (even if it compiles without).

Some of them like SimplifyIndVar and IntrinsicInst you are right can be removed.

Can you speak about some of the refactorings you are thinking of making? @Whitney has been recently making changes too, as in D73129 <https://reviews.llvm.org/D73129> if you have seen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73498/new/

https://reviews.llvm.org/D73498





More information about the llvm-commits mailing list