[PATCH] D70628: [Support] Enable file + line info in LLVM stack traces on Darwin.

Fri Jan 3 13:51:34 PST 2020

lhames added a comment.

In D70628#1762343 <https://reviews.llvm.org/D70628#1762343>, @hintonda wrote:

> In D70628#1762116 <https://reviews.llvm.org/D70628#1762116>, @hintonda wrote:
>
> > In D70628#1761330 <https://reviews.llvm.org/D70628#1761330>, @lhames wrote:
> >
> > > ...
> > >  I think the best long term solution to this problem is to teach llvm-symbolize how to cope with debug info in objects, rather than requiring a dSYM. An intermediate step (possibly generically useful) would be to add an option to llvm-symbolize to run llvm-dsymutil if there's no dSYM available.
> >
> >
> > I suppose that might be useful for individuals, but I don't think it would be a good idea for the bots, which is my primary target.
>
>
> My last comment concerned the intermediate step.  I think your long-term solution would be great.

If the option is added (and LLVM's stack symbolication call-out knows to use it) then I think it should work on the bots too, right? The only issue would be that crashing test cases would be slightly slower (since we'd have to produce the dSYMs).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70628/new/

https://reviews.llvm.org/D70628