[PATCH] D70628: [Support] Enable file + line info in LLVM stack traces on Darwin.

Fri Jan 3 14:50:06 PST 2020

dblaikie added a comment.

In D70628#1803671 <https://reviews.llvm.org/D70628#1803671>, @lhames wrote:

> In D70628#1762343 <https://reviews.llvm.org/D70628#1762343>, @hintonda wrote:
>
> > In D70628#1762116 <https://reviews.llvm.org/D70628#1762116>, @hintonda wrote:
> >
> > > In D70628#1761330 <https://reviews.llvm.org/D70628#1761330>, @lhames wrote:
> > >
> > > > ...
> > > >  I think the best long term solution to this problem is to teach llvm-symbolize how to cope with debug info in objects, rather than requiring a dSYM. An intermediate step (possibly generically useful) would be to add an option to llvm-symbolize to run llvm-dsymutil if there's no dSYM available.
> > >
> > >
> > > I suppose that might be useful for individuals, but I don't think it would be a good idea for the bots, which is my primary target.
> >
> >
> > My last comment concerned the intermediate step.  I think your long-term solution would be great.
>
>
> If the option is added (and LLVM's stack symbolication call-out knows to use it) then I think it should work on the bots too, right? The only issue would be that crashing test cases would be slightly slower (since we'd have to produce the dSYMs).

Bit of an aside: the speed of crashing tests in the presence of debug info is actually sort of important/currently a bit of a bottleneck - all gunit death tests (for instance, llvm::Error has a few of those) crash, and run the symbolizer as the normal part of the crash process. That symbolization is pretty slow currently in a debug/unoptimized build of the symbolizer itself. It'd be great to find a way to disable crash symbolizing for death tests. (I guess maybe this performance issue doesn't come up on the MachO platform because of the missing functionality that's causing it not to symbolize)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70628/new/

https://reviews.llvm.org/D70628