[PATCH] D70910: [compiler-rt] Add a critical section when flushing gcov counters

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 13:49:53 PST 2020


jfb added a comment.

> OK that helps a bit. I still don't understand though: why do you only need to protect flush and nothing else? You're protecting specific variables from being accesses concurrently only though flush, and not through the other paths that access those variables. Are these variables never accessed concurrently from these other functions?

Following up, I'd like to understand this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70910/new/

https://reviews.llvm.org/D70910





More information about the llvm-commits mailing list