[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

[David Tenty via Phabricator via llvm-commits]

daltenty requested changes to this revision.
daltenty added a comment.
This revision now requires changes to proceed.

I don't think that initialized global data should be coming out as label symbols (everything appears to be contained in a ".data" csect). As I understand it only static data should be glob'd into one big csect, as per  the XCOFF spec "An initialized definition for a global data scalar or structure ... is contained in its own csect". So each of these globals should have their own csect, which is the behavior exhibited by XLC.

I've observed that GCC on AIX is currently exhibiting this initalized-globals-in-one-csect behavior, but as we might expect, it interferes with the linkers ability to garbage collect unneeded global data.

I believe this is also an issue in the assembly path in D66154 <https://reviews.llvm.org/D66154>


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125