[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:18
 @over_aligned = local_unnamed_addr global double 9.000000e+02, align 32
- at charr = local_unnamed_addr global [4 x i8] c"abcd", align 1
+ at chrarray = local_unnamed_addr global [4 x i8] c"abcd", align 1
 @dblarr = local_unnamed_addr global [4 x double] [double 1.000000e+00, double 2.000000e+00, double 3.000000e+00, double 4.000000e+00], align 8
----------------
Minor nit: No need to change the name of this global.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:21
 
+ at a = common global i32 0, align 4
+ at b = common global i64 0, align 8
----------------
xingxue wrote:
> daltenty wrote:
> > I'm a bit confused why we are adding this, we don't refer to them in the object writing case. If it's to make sure we don't start emitting uninitialized data into .text shouldn't we have put some check-not's in?
> These are added to check if the addresses for `.bss` in the header are correct after the `.data` section.
Lets add the other members from  `aix-xcoff-common.ll` lit test, and perform the checking while dumping the object and then we can get rid of `aix-xcoff-common.ll`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125