[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

[Xing Xue via Phabricator via llvm-commits]

xingxue marked 3 inline comments as done.
xingxue added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:1
 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck %s
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff < %s | FileCheck %s
----------------
daltenty wrote:
> nit: I think it's worth while to add a comment to the beginning of this test indicating what we are hoping to test (i.e. initialized data). We are starting to have a lot of overlapping test cases, and for simplicity it would be nice to state the intent up front.
WIll do.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:21
 
+ at a = common global i32 0, align 4
+ at b = common global i64 0, align 8
----------------
daltenty wrote:
> I'm a bit confused why we are adding this, we don't refer to them in the object writing case. If it's to make sure we don't start emitting uninitialized data into .text shouldn't we have put some check-not's in?
These are added to check if the addresses for `.bss` in the header are correct after the `.data` section.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll:71
+
+; CHECK:      .comm   a,4,2
+; CHECK-NEXT: .comm   b,8,3
----------------
daltenty wrote:
> Do we want to check this? We currently don't in the object writing case (and this overlaps with aix-xcoff-common.ll).
Again, these are added to check if the addresses for `.bss` in the header are correct after the `.data` section.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125