[PATCH] D68472: [test] Use system locale for mri-utf8.test

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 04:44:18 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/mri-nonascii.test:6
+
+# Note: lit's Python will read this UTF-8 encoded mri-nonascii.txt file,
+# decode it to unicode. The filename in the redirection below will then
----------------
thopre wrote:
> MaskRay wrote:
> > OK, the fact that lit (Python) does some decoding/encoding make this tricky... Please let someone with a Windows machine verify this works.
> It does according to Owen's comment:
> 
> >>! In D68472#1699815, @gbreynoo wrote:
> > This functions on Windows fine.
Commit :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68472/new/

https://reviews.llvm.org/D68472





More information about the llvm-commits mailing list