[PATCH] D68472: [test] Use system locale for mri-utf8.test

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 05:31:34 PDT 2019


thakis added a comment.

This fails on macOS: http://45.33.8.238/mac/1350/step_10.txt

Relying on the system default locale seems a lot more brittle than relying on utf8. Requiring utf8 to be able to run llvm's tests seems like an ok requirement to me.

But in any case, please take a look at the breakage on Mac, and if it takes a while to fix please revert while you investigate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68472/new/

https://reviews.llvm.org/D68472





More information about the llvm-commits mailing list