[PATCH] D68472: [test] Use system locale for mri-utf8.test

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 04:05:16 PDT 2019


thopre marked 5 inline comments as done.
thopre added a comment.





================
Comment at: llvm/test/tools/llvm-ar/mri-nonascii.test:6
+
+# Note: lit's Python will read this UTF-8 encoded mri-nonascii.txt file,
+# decode it to unicode. The filename in the redirection below will then
----------------
MaskRay wrote:
> OK, the fact that lit (Python) does some decoding/encoding make this tricky... Please let someone with a Windows machine verify this works.
It does according to Owen's comment:

>>! In D68472#1699815, @gbreynoo wrote:
> This functions on Windows fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68472/new/

https://reviews.llvm.org/D68472





More information about the llvm-commits mailing list