[PATCH] D68729: [AMDGPU] Fixed dpp combine of VOP1

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 14:25:35 PDT 2019


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp:221-222
       ++NumOperands;
+    } else if (AMDGPU::getNamedOperandIdx(DPPOp,
+                   AMDGPU::OpName::src1_modifiers) != -1) {
+      DPPInst.addImm(0);
----------------
arsenm wrote:
> This case isn't tested
I do not think such instructions currently exists. VOP2 are tested by the original test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68729/new/

https://reviews.llvm.org/D68729





More information about the llvm-commits mailing list