[PATCH] D68729: [AMDGPU] Fixed dpp combine of VOP1

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp:221-222
       ++NumOperands;
+    } else if (AMDGPU::getNamedOperandIdx(DPPOp,
+                   AMDGPU::OpName::src1_modifiers) != -1) {
+      DPPInst.addImm(0);
----------------
This case isn't tested


================
Comment at: llvm/test/CodeGen/AMDGPU/dpp_combine.mir:530
+...
+
+# CHECK-LABEL: name: dpp_vop1
----------------
Add a comment explaining what this tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68729/new/

https://reviews.llvm.org/D68729