[PATCH] D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 19:13:00 PDT 2019


thakis added a comment.

In D65812#1617545 <https://reviews.llvm.org/D65812#1617545>, @Dor1s wrote:

> > Objection: .hpp is not idiomatic in LLVM.
>
> Thanks for the comment! I was wondering about that, but haven't found any guidelines restricting or discouraging this. Also, I've seen some `.hpp` files in LLVM.
>
> IMO `.hpp` makes much more sense for a header like this (C++ with implementation), especially given that it's a public header provided via "include" directory.
>
> With all of that, I'd prefer setting up a precedent for respecting `.hpp` files, assuming that I'm not violating any strict requirements :)




  $ git ls-files '*.hpp' | wc -l
        43
  $ git ls-files '*.h' | wc -l
      7151

And almost all of the existing 43 hpp files are test inputs. So +1 to the objection – we virtually don't have .hpp files in LLVM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65812/new/

https://reviews.llvm.org/D65812





More information about the llvm-commits mailing list