[PATCH] D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added a comment.

In D65812#1620267 <https://reviews.llvm.org/D65812#1620267>, @thakis wrote:

> In D65812#1617545 <https://reviews.llvm.org/D65812#1617545>, @Dor1s wrote:
>
> > > Objection: .hpp is not idiomatic in LLVM.
> >
> > Thanks for the comment! I was wondering about that, but haven't found any guidelines restricting or discouraging this. Also, I've seen some `.hpp` files in LLVM.
> >
> > IMO `.hpp` makes much more sense for a header like this (C++ with implementation), especially given that it's a public header provided via "include" directory.
> >
> > With all of that, I'd prefer setting up a precedent for respecting `.hpp` files, assuming that I'm not violating any strict requirements :)
>
>
>
>
>   $ git ls-files '*.hpp' | wc -l
>         43
>   $ git ls-files '*.h' | wc -l
>       7151
>
>
> And almost all of the existing 43 hpp files are test inputs. So +1 to the objection – we virtually don't have .hpp files in LLVM.


Nico, thanks for taking a look too. Ok, I'll rename it back to `\.h` tomorrow. Some documented guidance and/or stronger consistency might be helpful for cases like this in future. I think I tried to be reasonable and it didn't seem like I was going to violate any rules :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65812/new/

https://reviews.llvm.org/D65812