[PATCH] D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 12:26:01 PDT 2019


Dor1s added a comment.

> Objection: .hpp is not idiomatic in LLVM.

Thanks for the comment! I was wondering about that, but haven't found any guidelines restricting or discouraging this. Also, I've seen some `.hpp` files in LLVM.

IMO `.hpp` makes much more sense for a header like this (C++ with implementation), especially given that it's a public header provided via "include" directory.

With all of that, I'd prefer setting up a precedent for respecting `.hpp` files, assuming that I'm not violating any strict requirements :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65812/new/

https://reviews.llvm.org/D65812





More information about the llvm-commits mailing list