[PATCH] D62608: [ARM64, COFF] Add CodeView register mapping

Tom Tan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 12:12:44 PDT 2019


TomTan updated this revision to Diff 202466.
TomTan added a comment.

It makes sense to fix the dumper for test infrastructure. This update fixes register names in the dumper. I also changed the wildcard for register name to `ARM64_SP` in the new test, because register name is shown correct by the dumper based on `CPUType` in the PDB.

There is still a TODO item for printing to yaml. I haven't found a easy way to pass in `CPUType` for register name query. I'd like to get your advise on this and fix it later.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62608/new/

https://reviews.llvm.org/D62608

Files:
  include/llvm/DebugInfo/CodeView/CodeView.h
  include/llvm/DebugInfo/CodeView/CodeViewRegisters.def
  include/llvm/DebugInfo/CodeView/EnumTables.h
  include/llvm/DebugInfo/PDB/DIA/DIASession.h
  include/llvm/DebugInfo/PDB/IPDBSession.h
  include/llvm/DebugInfo/PDB/Native/NativeSession.h
  include/llvm/DebugInfo/PDB/PDBExtras.h
  include/llvm/DebugInfo/PDB/PDBTypes.h
  lib/DebugInfo/CodeView/EnumTables.cpp
  lib/DebugInfo/CodeView/SymbolDumper.cpp
  lib/DebugInfo/PDB/DIA/DIASession.cpp
  lib/DebugInfo/PDB/Native/NativeSession.cpp
  lib/DebugInfo/PDB/PDBExtras.cpp
  lib/ObjectYAML/CodeViewYAMLSymbols.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
  test/DebugInfo/COFF/register-variables-arm64.ll
  tools/llvm-pdbutil/MinimalSymbolDumper.cpp
  tools/llvm-pdbutil/PdbYaml.cpp
  tools/llvm-pdbutil/PrettyFunctionDumper.cpp
  unittests/DebugInfo/PDB/PDBApiTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62608.202466.patch
Type: text/x-patch
Size: 42671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190531/4fc26e5b/attachment.bin>


More information about the llvm-commits mailing list