[PATCH] D62608: [ARM64, COFF] Add CodeView register mapping

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 13:11:56 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: lib/DebugInfo/PDB/Native/NativeSession.cpp:86
 
-std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() {
+std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() const {
   return PDBSymbol::createAs<PDBSymbolExe>(*this, getNativeGlobalScope());
----------------
Did you mean to add const here? It doesn't seem necessary, please revert it if so.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62608/new/

https://reviews.llvm.org/D62608





More information about the llvm-commits mailing list