[PATCH] D57386: [SelectionDAG] Codesize: don't expand SHIFT to SHIFT_PARTS

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 05:13:39 PST 2019


SjoerdMeijer updated this revision to Diff 184278.
SjoerdMeijer added a comment.

Thanks for reviewing!

> The optForMinSize check should probably be in target-specific code

Agreed. I have created TLI.expandShift() to allow target-specific decision making.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57386/new/

https://reviews.llvm.org/D57386

Files:
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/Target/AArch64/AArch64ISelLowering.h
  lib/Target/ARM/ARMISelLowering.h
  lib/Target/X86/X86ISelLowering.h
  test/CodeGen/AArch64/shift_minsize.ll
  test/CodeGen/ARM/shift_minsize.ll
  test/CodeGen/X86/shift_minsize.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57386.184278.patch
Type: text/x-patch
Size: 15265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/4ae290a8/attachment.bin>


More information about the llvm-commits mailing list