[PATCH] D57386: [SelectionDAG] Codesize: don't expand SHIFT to SHIFT_PARTS

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 12:46:35 PST 2019


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2775
+  const bool MinSize = DAG.getMachineFunction().getFunction().optForMinSize();
+  if (!MinSize && LegalOrCustom) {
     // Expand the subcomponents.
----------------
The optForMinSize check should probably be in target-specific code; yes, the call is smaller on all the popular targets I can think of, but that's a function of the specific opcodes available, not a general rule.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57386/new/

https://reviews.llvm.org/D57386





More information about the llvm-commits mailing list