[PATCH] D57386: [SelectionDAG] Codesize: don't expand SHIFT to SHIFT_PARTS

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 05:20:36 PST 2019


lebedev.ri added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:648
+  /// reasons).
+  virtual bool expandShift(SelectionDAG &DAG, SDNode *N) const {
+    return true;
----------------
It probably should be `shouldExpandShift` or something?
Just `expandShift` reads as "call this function to expand the shift operation"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57386/new/

https://reviews.llvm.org/D57386





More information about the llvm-commits mailing list