[PATCH] D56877: GlobalISel: Implemet narrowScalar for mul

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 10:09:41 PST 2019


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with minor change.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1640
+  LLT HalfTy = LLT::scalar(NewSize);
+  // TODO: if HalfTy != NewTy, handle the breakdown all at once?
+
----------------
Need a check here to verify that NewTy == HalfTy otherwise bail out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56877/new/

https://reviews.llvm.org/D56877





More information about the llvm-commits mailing list