[PATCH] D56877: GlobalISel: Implemet narrowScalar for mul

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1640
+  LLT HalfTy = LLT::scalar(NewSize);
+  // TODO: if HalfTy != NewTy, handle the breakdown all at once?
+
----------------
aemerson wrote:
> Need a check here to verify that NewTy == HalfTy otherwise bail out.
That's what I did originally, but this does break it down so that the newly created muls are broken down later. I originally had a test case with s128 mul, but it also requires narrowing for the shifts to be implemented


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56877/new/

https://reviews.llvm.org/D56877