[PATCH] D56242: Elevate instructions across if-else blocks for better constant propagation

Ayonam Ray via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 6 06:25:18 PST 2019


ayonam added a subscriber: lebedev.ri.
ayonam added a comment.

In D56242#1344627 <https://reviews.llvm.org/D56242#1344627>, @lebedev.ri wrote:

> Hm, why i'm the reviewer here?


Sorry, I somehow got the impression that you were also looking after the regression test framework and hence thought that you should review the test case part of it.

> That being said, is "elevation" == "hoisting" here?
>  That might be a better, more common name..

Yes, it actually is so.  But since there was already a pass by that name, I thought I'd name mine differently so as not to confuse one with the other.  Any suggestions to rename the new pass is most welcome.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56242/new/

https://reviews.llvm.org/D56242





More information about the llvm-commits mailing list