[PATCH] D56242: Elevate instructions across if-else blocks for better constant propagation

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 14:45:23 PST 2019


fhahn added a comment.

Thanks for the patch! I plan to have a closer look in the next few days.

In the meantime, could you run clang-format on your patch and update it?

Also, do you have any benchmark results for the new pass or any statistics on how often this hoisting is applied for larger programs (you could use LLVM's Statistic infrastructure http://llvm.org/docs/ProgrammersManual.html#the-statistic-class-stats-option)?

Cheers,
Florian


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56242/new/

https://reviews.llvm.org/D56242





More information about the llvm-commits mailing list