[PATCH] D56242: Elevate instructions across if-else blocks for better constant propagation

[Ayonam Ray via Phabricator via llvm-commits]

ayonam added a comment.

In D56242#1345736 <https://reviews.llvm.org/D56242#1345736>, @fhahn wrote:

> Thanks for the patch! I plan to have a closer look in the next few days.


Thanks Florian for agreeing to review the patch.

> In the meantime, could you run clang-format on your patch and update it?

Yes, I will do so.  There are a few lines of code that were added in the last minute by another engineer and I think that caused the divergence from the standards.

> Also, do you have any benchmark results for the new pass or any statistics on how often this hoisting is applied for larger programs (you could use LLVM's Statistic infrastructure http://llvm.org/docs/ProgrammersManual.html#the-statistic-class-stats-option)?

I know that there is a piece of code in an industry benchmark that displays this kind of a pattern.  In fact, the test case is modelled on that piece of code by changing the structure so as to avoid IP conflicts.

I will nevertheless try the LLVM's Statistic Infrastructure to see if I can get more instances.

Thanks and regards
Ayonam


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56242/new/

https://reviews.llvm.org/D56242