[PATCH] D53627: [HotColdSplitting] Identify larger cold regions using domtree queries

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 170944.
vsk added a comment.
This revision is now accepted and ready to land.

Fixed a bug in CodeExtractor found by building the test suite with an asserts-enabled compiler.

CodeExtractor should assert that the codeReplacer block provides exactly one (unique) incoming value to any phi node with incoming values from the extracted region.

I'd appreciate another look at that change, just to make sure it's ok. I added a test in 'duplicate-phi-preds-crash.ll'. Thanks!


https://reviews.llvm.org/D53627

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Transforms/HotColdSplit/do-not-split.ll
  llvm/test/Transforms/HotColdSplit/duplicate-phi-preds-crash.ll
  llvm/test/Transforms/HotColdSplit/multiple-exits.ll
  llvm/test/Transforms/HotColdSplit/outline-if-then-else.ll
  llvm/test/Transforms/HotColdSplit/outline-while-loop.ll
  llvm/test/Transforms/HotColdSplit/split-cold-1.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53627.170944.patch
Type: text/x-patch
Size: 28413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/1ee52b5c/attachment.bin>