[PATCH] D53627: [HotColdSplitting] Identify larger cold regions using domtree queries

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 11:21:33 PDT 2018


vsk planned changes to this revision.
vsk marked 2 inline comments as done.
vsk added a comment.

I've been fuzzing+testing this patch further and found a verification failure in CodeExtractor. As we now support outlining regions with multiple exits, CodeExtractor cannot leave around duplicate incoming values from the codeRepl block. I think this should be simple to fix.

Test: F7448253: duplicate-phi-preds-crash.ll <https://reviews.llvm.org/F7448253>


https://reviews.llvm.org/D53627





More information about the llvm-commits mailing list