[PATCH] D53627: [HotColdSplitting] Identify larger cold regions using domtree queries

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 170954.
vsk added a reviewer: kuhar.
vsk added a comment.

- Disable a problematic CodeExtractor unit test. CodeExtractor miscompiles the code in the test. Any time there are live output values from an outlined region, there's a chance CodeExtractor will leave around a phi node with incoming values from a different function.


https://reviews.llvm.org/D53627

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Transforms/HotColdSplit/do-not-split.ll
  llvm/test/Transforms/HotColdSplit/duplicate-phi-preds-crash.ll
  llvm/test/Transforms/HotColdSplit/multiple-exits.ll
  llvm/test/Transforms/HotColdSplit/outline-if-then-else.ll
  llvm/test/Transforms/HotColdSplit/outline-while-loop.ll
  llvm/test/Transforms/HotColdSplit/split-cold-1.ll
  llvm/unittests/Transforms/Utils/CodeExtractorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53627.170954.patch
Type: text/x-patch
Size: 29985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/29287ba8/attachment.bin>