[PATCH] D41949: [RISCV] implement li pseudo instruction

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 07:37:35 PDT 2018


asb added a comment.

In https://reviews.llvm.org/D41949#1046704, @niosHD wrote:

> In https://reviews.llvm.org/D41949#1045516, @asb wrote:
>
> > I haven't looked into it more closely, but I do note a minor codegen change for float-mem.ll which results in an extra instruction:
>
>
> Good catch, I missed that codegen change. Seems like the ADDI was previously merged into the FLW. Given that we can solely use PseudoLI for constants we probably only miss a simplification pattern or a simple peephole optimisation. I can have a look but given that I currently do not use floating point instructions it may take some time.


I'm mainly surprised that we're seeing this codegen change for floating point but not integer loads/stores. I'll try to take a closer look at it before committing, but it's not something that should block this patch anyway.


https://reviews.llvm.org/D41949





More information about the llvm-commits mailing list